HLM-5167 HLM-5158 adding navigation and respective restrictions #257

siddhant-nawale-egov · 2024-04-03T15:37:57Z

Adding navigation and respective restrictions

Summary by CodeRabbit

New Features
- Introduced a dynamic icon display in buttons based on conditions.
- Added new components like ActionBar, Stepper, and Toast to enhance the microplanning process for employees.
- Implemented a new data storage solution for session management.
- Enhanced navigation with ArrowBack and ArrowForward components.
- Integrated Link component for improved guideline navigation.
Bug Fixes
- Refined data completeness checks and state management in the RuleEngine component.
UI Changes
- Updated modal heading styles and microplanning card filtering logic.
- Replaced TimelineMicroplan with a more interactive Stepper component.
- Adjusted Toast component styling and positioning.
Refactor
- Improved handling of data storage and retrieval.
Chores
- Updated CSS version in the public index file to 1.0.8-microplan.

coderabbitai · 2024-04-03T15:38:12Z

Walkthrough

The recent updates focus on enhancing UI components, refining state management, and improving data handling across various components in the HCM microplanning module. Key changes include conditional rendering, UI refreshes, the introduction of new components for a more intuitive user experience, and better data storage practices. These modifications aim to streamline the microplanning process, making it more efficient and user-friendly.

Changes

File Path	Change Summary
`.../ComonComponents.js`	Added conditional rendering for icons and updated `ModalHeading` styling.
`.../MicroplanningCard.js`	Added filtering for `links` based on roles.
`.../CreateMicroplan.js`	Introduced new components and state management for `microplanData`, enhanced UI with `Stepper`, and improved data storage handling.
`.../Guidelines.js`	Updated to include `Link` component with dynamic path calculation.
`.../RuleEngine.js`, `.../Upload.js`	Enhanced data handling with new state variables and `useEffect` hooks, refined UI elements, and data completeness checks.
`.../public/index.html`	Updated CSS file version.

A hop, a skip, in the code we dip,
To tweak and tune, under the moon.
With each line we craft, a clearer path,
🌟 For planners to glide, with ease by their side.
In the world of bytes, we reach new heights,
🐰 With every change, we set the stage.
For a future so bright, in the digital night.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 18

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 8e83bb3 and d04bbc5.

Files ignored due to path filters (2)

micro-ui/web/micro-ui-internals/packages/css/package.json is excluded by !**/*.json
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/package.json is excluded by !**/*.json

Files selected for processing (11)

micro-ui/web/micro-ui-internals/example/public/index.html (1 hunks)
micro-ui/web/micro-ui-internals/packages/css/src/components/microplanning.scss (24 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/ComonComponents.js (2 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanningCard.js (1 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/CreateMicroplan.js (1 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Guidelines.js (1 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Hypothesis.js (8 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/RuleEngine.js (5 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js (7 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/index.js (1 hunks)
micro-ui/web/public/index.html (1 hunks)

Files skipped from review due to trivial changes (1)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/index.js

Additional Context Used

Path-based Instructions (7)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/ComonComponents.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Guidelines.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanningCard.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/CreateMicroplan.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Hypothesis.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/RuleEngine.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js (1)

Pattern **/*.js: check

Learnings (1)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js (3)

User: siddhant-nawale-egov"
PR: egovernments/DIGIT-Frontend#204
File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:0-0
Timestamp: 2024-03-13T05:11:36.400Z
Learning: A more detailed message for file parsing errors in the `Upload.js` file is displayed elsewhere in the code, as clarified by the user.

User: siddhant-nawale-egov"
PR: egovernments/DIGIT-Frontend#204
File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:468-481
Timestamp: 2024-03-13T07:33:45.211Z
Learning: The error message in the `checkForErrorInUploadedFile` function within `Upload.js` is being localized and improved for better user experience, as clarified by the user.

User: siddhant-nawale-egov"
PR: egovernments/DIGIT-Frontend#214
File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:14-17
Timestamp: 2024-03-15T12:20:50.090Z
Learning: The `geojsonValidations` is a utility developed within the DIGIT-Frontend project, not an external dependency.

Additional comments not posted (11)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/ComonComponents.js (2)

16-20: The conditional rendering based on props.download in ButtonType2 is correctly implemented and enhances the component's flexibility.

28-28: The update in ModalHeading to allow dynamic class names and inline styling enhances the component's flexibility. Ensure that props.style is properly sanitized if it's user-controlled to avoid potential security issues.

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Guidelines.js (1)

5-27: The addition of the Link component and the newPath calculation in Guidelines enhance navigation. Ensure that window.contextPath is always defined and sanitized to prevent potential security issues.

micro-ui/web/micro-ui-internals/example/public/index.html (1)

14-14: The addition of the new stylesheet link for @egovernments/digit-ui-css version 1.8.2-coreui.2 is noted. Ensure that both stylesheet links are necessary and do not conflict with each other.

micro-ui/web/public/index.html (1)

17-17: Updating the version of the CSS file link to 1.0.8-microplan is noted. Ensure that the new version is tested across different browsers for compatibility.

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanningCard.js (1)

41-41: The addition of a filter condition to check if each link has roles with at least one role assigned enhances role-based access control. Ensure that the utility function Digit.Utils.didEmployeeHasAtleastOneRole is correctly implemented and tested.

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/CreateMicroplan.js (1)

1-149: The comprehensive updates in CreateMicroplan enhance navigation, state management, and UI consistency. Ensure that the effects are correctly triggered, navigation handling functions are reviewed for correctness, and data stored in session storage is correctly serialized and deserialized.

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Hypothesis.js (1)

27-59: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-301]

The enhancements in Hypothesis improve data handling and UI consistency. Ensure that the data passed through props is correctly used, useEffect hooks are correctly implemented to avoid unnecessary re-renders, and UI adjustments are reviewed for consistency and accessibility.

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/RuleEngine.js (1)

42-68: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-143]

The enhancements in RuleEngine improve data handling and state management. Ensure that the data passed through props is correctly used, useEffect hooks are correctly implemented to avoid unnecessary re-renders, and the data completeness logic is thoroughly tested for accuracy.
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js (2)
18-24: Ensure the newly added state variables microplanData, setMicroplanData, checkDataCompletion, and setCheckDataCompletion are properly documented.
Adding comments to explain the purpose of these state variables will enhance code readability and maintainability, especially for new developers or when revisiting the code after some time.

54-57: Verify the logic within the useEffect hook for setting checkDataCompletion.
  useEffect(() => {
-   if (!setCheckDataCompletion) return;
+   if (typeof setCheckDataCompletion !== 'function') return;
    setCheckDataCompletion("valid");
  }, [checkDataCompletion]);
Ensure that setCheckDataCompletion is a function before invoking it. This prevents potential runtime errors if setCheckDataCompletion is mistakenly set to a non-function value.

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js

micro-ui/web/micro-ui-internals/packages/css/src/components/microplanning.scss

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js

coderabbitai

Actionable comments posted: 6

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between d04bbc5 and 0e9b345.

Files selected for processing (4)

micro-ui/web/micro-ui-internals/packages/css/src/components/microplanning.scss (26 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/CreateMicroplan.js (1 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Guidelines.js (1 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/RuleEngine.js (6 hunks)

Files skipped from review as they are similar to previous changes (3)

micro-ui/web/micro-ui-internals/packages/css/src/components/microplanning.scss
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Guidelines.js
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/RuleEngine.js

Additional Context Used

Path-based Instructions (1)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/CreateMicroplan.js (1)

Pattern **/*.js: check

Additional comments not posted (1)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/CreateMicroplan.js (1)

150-154: LGTM! The LoadCustomComponent is implemented correctly and handles the rendering of dynamic components efficiently.

.../micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/CreateMicroplan.js

coderabbitai

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 0e9b345 and 7185f07.

Files selected for processing (1)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/CreateMicroplan.js (1 hunks)

Additional Context Used

Path-based Instructions (1)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/CreateMicroplan.js (1)

Pattern **/*.js: check

Learnings (1)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/CreateMicroplan.js (2)

User: siddhant-nawale-egov"
URL: https://github.com/egovernments/DIGIT-Frontend/pull/257

Timestamp: 2024-04-04T05:04:10.806Z
Learning: The `onStepClick` logic in `CreateMicroplan.js` is intentionally commented out to allow developers to navigate between screens during development, even though not all screens are made yet.

User: siddhant-nawale-egov"
URL: https://github.com/egovernments/DIGIT-Frontend/pull/257

Timestamp: 2024-04-04T04:56:40.263Z
Learning: The Button component from `@egovernments/digit-ui-components` has compatibility issues with the ActionBar, leading to the preference for using the Button from `@egovernments/digit-ui-react-components` in certain scenarios.

Additional comments not posted (7)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/CreateMicroplan.js (7)

1-3: Consider consolidating imports from @egovernments/digit-ui-components and @egovernments/digit-ui-react-components for improved readability and maintainability, but keep in mind the compatibility issues previously mentioned regarding the Button component.

11-11: Using the Button component from @egovernments/digit-ui-react-components due to compatibility issues with the ActionBar is a valid approach. Ensure to monitor for any updates that might resolve this issue.

38-49: Ensure the logic within the useEffect hook for data completion validation is clear and concise. Consider revising the condition to directly address the scenario that triggers the toast notification, as previously discussed.

60-71: The separation of useEffect hooks for storing and retrieving microplanData in session storage is appropriate given their distinct purposes. This approach aligns with React best practices for persisting and initializing state.

73-79: The nextStep function correctly handles the edge case where currentPage is undefined, preventing potential runtime errors. This is a good practice for robust error handling.

101-105: Given the intentional commenting out of the onStepClick logic to facilitate development navigation, ensure to uncomment or properly implement this functionality once all screens are made. This temporary measure should be addressed to avoid confusion in the future.

144-145: The implementation of the Toast component for displaying notifications based on the toast state is well-handled. This enhances user feedback mechanisms within the application.

coderabbitai

Actionable comments posted: 5

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 7185f07 and 8129450.

Files selected for processing (5)

micro-ui/web/micro-ui-internals/packages/css/src/components/microplanning.scss (26 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Nagivator.js (1 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/CreateMicroplan.js (1 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js (9 hunks)
micro-ui/web/public/index.html (1 hunks)

Files skipped from review as they are similar to previous changes (3)

micro-ui/web/micro-ui-internals/packages/css/src/components/microplanning.scss
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/CreateMicroplan.js
micro-ui/web/public/index.html

Additional Context Used

Path-based Instructions (2)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Nagivator.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js (1)

Pattern **/*.js: check

Learnings (1)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js (3)

User: siddhant-nawale-egov"
PR: egovernments/DIGIT-Frontend#214
File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:14-17
Timestamp: 2024-03-15T12:20:50.090Z
Learning: The `geojsonValidations` is a utility developed within the DIGIT-Frontend project, not an external dependency.

User: siddhant-nawale-egov"
PR: egovernments/DIGIT-Frontend#204
File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:0-0
Timestamp: 2024-03-13T05:11:36.400Z
Learning: A more detailed message for file parsing errors in the `Upload.js` file is displayed elsewhere in the code, as clarified by the user.

User: siddhant-nawale-egov"
PR: egovernments/DIGIT-Frontend#204
File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:468-481
Timestamp: 2024-03-13T07:33:45.211Z
Learning: The error message in the `checkForErrorInUploadedFile` function within `Upload.js` is being localized and improved for better user experience, as clarified by the user.

Additional comments not posted (5)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Nagivator.js (1)

16-146: Ensure proper error handling and validation in the Navigator component's logic.
While the component includes checks for data completion and navigation events, it's crucial to also consider error scenarios that might arise during navigation or data validation. This could include handling API failures, invalid state transitions, or unexpected user inputs.

Consider adding try-catch blocks or error boundaries where appropriate, and ensure that any external calls or operations that might fail are adequately guarded against to prevent the application from crashing or entering an invalid state.
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js (4)
16-16: Remove the unused import of Toast from @egovernments/digit-ui-components.
- import { Toast } from "@egovernments/digit-ui-components";
Given the context from previous comments and the clarification provided, it appears this import is actually used within the component. Please disregard this suggestion if the Toast component from @egovernments/digit-ui-components is indeed utilized.

598-598: Consider adding the download attribute dynamically based on the file type.
-          footerRightButtonBody={<ButtonType2 text={t("DOWNLOAD_TEMPLATE")} download={true} />}
+          footerRightButtonBody={<ButtonType2 text={t("DOWNLOAD_TEMPLATE")} download={selectedFileType.id === "Excel"} />}
Given the clarification that the download option is used for the icon's appearance and does not control file download functionality, this suggestion may not be applicable. Please disregard if the current implementation meets the intended design.

666-677: Refine the positioning and styling of the Toast component for better UI consistency.
-        <Toast style={{ bottom: "5.5rem" }} label={toast.message} onClose={() => setToast(null)} />
+        <Toast style={{ bottom: "5.5rem", right: "1rem", position: "fixed" }} label={toast.message} onClose={() => setToast(null)} />
Considering the clarification regarding the Toast component's styling, it's understood that the primary intent was to adjust its vertical positioning. No further action is required on the additional styling suggestions.

733-742: Consider removing the hover effect logic if it's not being utilized in the UI.
If the hover effect on the upload options is a required feature, ensure that the corresponding CSS classes or styles are implemented to reflect the hover state visually. Otherwise, removing unused logic can simplify the component.

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Nagivator.js

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js

coderabbitai

Actionable comments posted: 6

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 8129450 and a8eb928.

Files selected for processing (2)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Nagivator.js (1 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js (9 hunks)

Files skipped from review as they are similar to previous changes (1)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Nagivator.js

Additional Context Used

Path-based Instructions (1)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js (1)

Pattern **/*.js: check

Learnings (1)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js (3)

User: siddhant-nawale-egov"
PR: egovernments/DIGIT-Frontend#214
File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:14-17
Timestamp: 2024-03-15T12:20:50.090Z
Learning: The `geojsonValidations` is a utility developed within the DIGIT-Frontend project, not an external dependency.

User: siddhant-nawale-egov"
PR: egovernments/DIGIT-Frontend#204
File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:0-0
Timestamp: 2024-03-13T05:11:36.400Z
Learning: A more detailed message for file parsing errors in the `Upload.js` file is displayed elsewhere in the code, as clarified by the user.

User: siddhant-nawale-egov"
PR: egovernments/DIGIT-Frontend#204
File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:468-481
Timestamp: 2024-03-13T07:33:45.211Z
Learning: The error message in the `checkForErrorInUploadedFile` function within `Upload.js` is being localized and improved for better user experience, as clarified by the user.

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js

coderabbitai

Actionable comments posted: 5

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between a8eb928 and 9274748.

Files selected for processing (2)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/ComonComponents.js (2 hunks)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js (9 hunks)

Files skipped from review as they are similar to previous changes (1)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/ComonComponents.js

Additional Context Used

Path-based Instructions (1)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js (1)

Pattern **/*.js: check

Learnings (1)

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js (4)

User: siddhant-nawale-egov"
URL: https://github.com/egovernments/DIGIT-Frontend/pull/257

Timestamp: 2024-04-04T11:18:00.561Z
Learning: The `Toast` component's styling is managed internally within the component, ensuring consistency and adaptability across different contexts without the need for additional external styling.

User: siddhant-nawale-egov"
PR: egovernments/DIGIT-Frontend#214
File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:14-17
Timestamp: 2024-03-15T12:20:50.090Z
Learning: The `geojsonValidations` is a utility developed within the DIGIT-Frontend project, not an external dependency.

User: siddhant-nawale-egov"
PR: egovernments/DIGIT-Frontend#204
File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:0-0
Timestamp: 2024-03-13T05:11:36.400Z
Learning: A more detailed message for file parsing errors in the `Upload.js` file is displayed elsewhere in the code, as clarified by the user.

User: siddhant-nawale-egov"
PR: egovernments/DIGIT-Frontend#204
File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:468-481
Timestamp: 2024-03-13T07:33:45.211Z
Learning: The error message in the `checkForErrorInUploadedFile` function within `Upload.js` is being localized and improved for better user experience, as clarified by the user.

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js

HLM-5167 HLM-5158 adding navigation and respective restrictions

d04bbc5

siddhant-nawale-egov self-assigned this Apr 3, 2024

siddhant-nawale-egov requested a review from nipunarora-eGov as a code owner April 3, 2024 15:37

coderabbitai bot requested changes Apr 3, 2024

View reviewed changes

siddhant-nawale-egov commented Apr 3, 2024

View reviewed changes

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js Outdated Show resolved Hide resolved

siddhant-nawale-egov commented Apr 3, 2024

View reviewed changes

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js Show resolved Hide resolved

siddhant-nawale-egov commented Apr 3, 2024

View reviewed changes

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js Show resolved Hide resolved

coderabbitai bot approved these changes Apr 3, 2024

View reviewed changes

HLM-5167 adding review changes

0e9b345

coderabbitai bot requested changes Apr 4, 2024

View reviewed changes

HLM-5167 adding review changes

7185f07

coderabbitai bot reviewed Apr 4, 2024

View reviewed changes

siddhant-nawale-egov added 2 commits April 4, 2024 10:43

HLM-5167 adding ui component css in web public file

69fe078

HLM-5167 created a separate navigator component

8129450

coderabbitai bot requested changes Apr 4, 2024

View reviewed changes

HLM-5167 adding review changes

a8eb928

coderabbitai bot requested changes Apr 4, 2024

View reviewed changes

siddhant-nawale-egov commented Apr 4, 2024

View reviewed changes

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js Show resolved Hide resolved

siddhant-nawale-egov commented Apr 4, 2024

View reviewed changes

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js Show resolved Hide resolved

siddhant-nawale-egov commented Apr 4, 2024

View reviewed changes

micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js Show resolved Hide resolved

HLM-5167 changing buttontype2 porps

9274748

nipunarora-eGov approved these changes Apr 4, 2024

View reviewed changes

coderabbitai bot requested changes Apr 4, 2024

View reviewed changes

coderabbitai bot approved these changes Apr 4, 2024

View reviewed changes

nipunarora-eGov merged commit fbf8926 into microplan Apr 4, 2024
2 checks passed

nipunarora-eGov deleted the HLM-5167-HLM-5168 branch April 4, 2024 11:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HLM-5167 HLM-5158 adding navigation and respective restrictions #257

HLM-5167 HLM-5158 adding navigation and respective restrictions #257

siddhant-nawale-egov commented Apr 3, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 3, 2024 •

edited

Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

HLM-5167 HLM-5158 adding navigation and respective restrictions #257

HLM-5167 HLM-5158 adding navigation and respective restrictions #257

Conversation

siddhant-nawale-egov commented Apr 3, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Apr 3, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

siddhant-nawale-egov commented Apr 3, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 3, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)